Paths

Table of Contentst

Differential D12818

Convert "profile" image transforms to the new pathway
ClosedPublic
Actions

Authored by epriestley on May 12 2015, 10:56 PM.

Tags

None

Referenced Files

	F13095957: D12818.id30836.diff
	Thu, Apr 25, 1:31 PM

	F13095956: D12818.id30808.diff
	Thu, Apr 25, 1:31 PM

	F13095955: D12818.id.diff
	Thu, Apr 25, 1:30 PM

	F13089940: D12818.diff
	Thu, Apr 25, 2:08 AM

	Unknown Object (File)
	Sat, Apr 20, 8:05 PM

	Unknown Object (File)
	Tue, Apr 16, 4:50 PM

	Unknown Object (File)
	Sat, Apr 13, 10:02 PM

	Unknown Object (File)
	Sat, Apr 13, 10:02 PM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7707: Implement a read-through cache layer

Commits

Restricted Diffusion Commit
rP7e365eb8ae8c: Convert "profile" image transforms to the new pathway

Summary

Ref T7707. This ends up being sort of complicated: to support 100x100 images in T4406, we need to scale small images up so they look OK when we scale them back down with background-size in CSS.

The rest of it is mostly straightforward.

Test Plan

Did an OAuth handshake and saw a scaled-up, scaled-down profile picture that looked correct.
Used Pholio, edited pholio, embedded pholio.
Uploaded a bunch of small/weird/big images and regenerated all their transforms.
Uploaded some text files into Pholio.
Grepped for removed methods, etc.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30808.May 12 2015, 10:56 PM

epriestley retitled this revision from to Convert "profile" image transforms to the new pathway.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7707: Implement a read-through cache layer.

Herald added a reviewer: chad. · View Herald TranscriptMay 12 2015, 10:56 PM

Herald added a subscriber: epriestley. · View Herald Transcript

btrahan accepted this revision.May 12 2015, 11:25 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 12 2015, 11:25 PM

Closed by commit rP7e365eb8ae8c: Convert "profile" image transforms to the new pathway (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2015, 6:40 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

view/

PhabricatorAuthAccountView.php

8 lines

files/

PhabricatorImageTransformer.php

30 lines

controller/

PhabricatorFileTransformController.php

86 lines

storage/

PhabricatorFile.php

8 lines

transform/

PhabricatorFileImageTransform.php

36 lines

PhabricatorFileThumbnailTransform.php

37 lines

macro/

query/

PhabricatorMacroSearchEngine.php

8 lines

pholio/

query/

PholioMockSearchEngine.php

11 lines

view/

PholioMockEmbedView.php

16 lines

PholioMockImagesView.php

9 lines

PholioUploadedImageView.php

6 lines

webroot/

rsrc/

css/

application/

auth/

1 line

image/

icon/

fatcow/

thumbnails/

default280x210.png

image280x210.png

Diff 30836

src/applications/auth/view/PhabricatorAuthAccountView.php

Loading...

src/applications/files/PhabricatorImageTransformer.php

Loading...

src/applications/files/controller/PhabricatorFileTransformController.php

Loading...

src/applications/files/storage/PhabricatorFile.php

Loading...

src/applications/files/transform/PhabricatorFileImageTransform.php

Loading...

src/applications/files/transform/PhabricatorFileThumbnailTransform.php

Loading...

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...

src/applications/pholio/view/PholioMockEmbedView.php

Loading...

src/applications/pholio/view/PholioMockImagesView.php

Loading...

src/applications/pholio/view/PholioUploadedImageView.php

Loading...

webroot/rsrc/css/application/auth/auth.css

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/default280x210.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/image280x210.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/pdf280x210.png

Loading...

webroot/rsrc/image/icon/fatcow/thumbnails/zip280x210.png

Loading...