Page MenuHomePhabricator
Differential D12815

Calendar month view "today" indicator should be a blue bar across the bottom of the day cell
ClosedPublic
Actions

Authored by lpriestley on May 12 2015, 8:17 PM.
Tags
None
Referenced Files
F14046252: D12815.id30796.diff
Wed, Nov 13, 7:29 PM
F14009202: D12815.diff
Wed, Oct 30, 12:19 PM
F14005786: D12815.diff
Sun, Oct 27, 7:46 PM
F13997953: D12815.id30798.diff
Thu, Oct 24, 7:00 AM
F13980708: D12815.id30797.diff
Oct 19 2024, 12:15 PM
F13978939: D12815.id30795.diff
Oct 19 2024, 1:45 AM
F13965414: D12815.id.diff
Oct 16 2024, 1:55 AM
Unknown Object (File)
Oct 9 2024, 7:19 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4392: Implement "Month" calendar mock
Commits
Restricted Diffusion Commit
rP8e9ee8635792: Calendar month view "today" indicator should be a blue bar across the bottom…
Summary

Ref T4392, Calendar month view "today" indicator should be a blue bar across the bottom of the day cell

Test Plan

Open month view of Calendar, today should have a blue bar across the bottom of the day cell

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30795.May 12 2015, 8:17 PM
lpriestley retitled this revision from to Calendar month view "today" indicator should be a blue bar across the bottom of the day cell.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T4392: Implement "Month" calendar mock.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 12 2015, 8:17 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 30796.May 12 2015, 8:18 PM
lpriestley edited edge metadata.

Celerity map

epriestley accepted this revision.May 12 2015, 8:19 PM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/css/phui/calendar/phui-calendar-month.css
54

text-align is probably unnecessary.

Consider using a div instead of a span with display: block.

This revision is now accepted and ready to land.May 12 2015, 8:19 PM
lpriestley updated this revision to Diff 30797.May 12 2015, 8:21 PM
lpriestley edited edge metadata.

css trimming

lpriestley marked an inline comment as done.May 12 2015, 8:21 PM
Closed by commit rP8e9ee8635792: Calendar month view "today" indicator should be a blue bar across the bottom… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 12 2015, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
calendar/
25 lines
webroot/
rsrc/
css/
phui/
calendar/
18 lines

Diff 30798

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarMonthView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-month.css

Loading...
Phabricator · Built by Phacility