Page MenuHomePhabricator
Differential D12808

Modularize file transforms and provide a "transforms" UI
ClosedPublic
Actions

Authored by epriestley on May 12 2015, 2:18 PM.
Tags
None
Referenced Files
F15473538: D12808.id30786.diff
Sat, Apr 5, 11:24 PM
F15451067: D12808.diff
Fri, Mar 28, 7:58 PM
F15418196: D12808.id30829.diff
Thu, Mar 20, 9:28 PM
F15409964: D12808.id30786.diff
Wed, Mar 19, 6:13 AM
F15406655: D12808.id.diff
Tue, Mar 18, 1:09 PM
F15401572: D12808.diff
Mon, Mar 17, 6:19 PM
Unknown Object (File)
Mar 2 2025, 2:42 PM
Unknown Object (File)
Feb 21 2025, 8:06 PM
View All Files
Subscribers
chad
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7707: Implement a read-through cache layer
Commits
Restricted Diffusion Commit
rPc998e44b5a35: Modularize file transforms and provide a "transforms" UI
Summary

Ref T7707. Available transforms are currently relatively hard-coded and don't really have any support UI.

Modularize them so we can build some support UI.

This doesn't actually use any of the new stuff yet: I want to make a clean cutover once I fix the aspect ratio stuff so I can pick up a cachekey/URI change as a side effect.

Test Plan

Screen Shot 2015-05-12 at 7.05.55 AM.png (837×1 px, 166 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30786.May 12 2015, 2:18 PM
epriestley retitled this revision from to Modularize file transforms and provide a "transforms" UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7707: Implement a read-through cache layer.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 12 2015, 2:18 PM
chad added a subscriber: chad.May 12 2015, 2:43 PM

itsawesome

btrahan accepted this revision.May 12 2015, 6:26 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 12 2015, 6:26 PM
Closed by commit rPc998e44b5a35: Modularize file transforms and provide a "transforms" UI (authored by epriestley, committed by epriestley). · Explain WhyMay 13 2015, 6:39 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T12614: Add file transform unit tests.Apr 21 2017, 3:05 PM

Revision Contents
Changeset List

Diff 30829

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/files/application/PhabricatorFilesApplication.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileInfoController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileTransformController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileTransformListController.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

src/applications/files/transform/PhabricatorFileImageTransform.php

Loading...
View Options

src/applications/files/transform/PhabricatorFileThumbnailTransform.php

Loading...
View Options

src/applications/files/transform/PhabricatorFileTransform.php

Loading...
Phabricator · Built by Phacility