Page MenuHomePhabricator

Don't trim remarkup corpora before summarizing
ClosedPublic

Authored by epriestley on May 11 2015, 3:30 PM.
Tags
None
Referenced Files
F15397611: D12794.diff
Sun, Mar 16, 9:19 PM
F15393747: D12794.id.diff
Sat, Mar 15, 11:05 PM
F15393465: D12794.id30755.diff
Sat, Mar 15, 9:00 PM
F15392732: D12794.id30754.diff
Sat, Mar 15, 5:18 PM
F15386884: D12794.id30754.diff
Sat, Mar 15, 1:26 AM
F15381811: D12794.diff
Fri, Mar 14, 9:25 AM
F15337900: D12794.id30755.diff
Sun, Mar 9, 8:18 AM
F15334208: D12794.diff
Sat, Mar 8, 7:33 AM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP75fc4e763ad6: Don't trim remarkup corpora before summarizing
Summary

Currently, lists like this:

- a
- b
- c

...get trimmed before summarization and end up looking like this after summarization:

- a
  - b
  - c

This produces the summary artifacts (first item at wrong indent level):

Screen Shot 2015-05-11 at 8.29.34 AM.png (238×686 px, 30 KB)

Instead, don't trim. This produces better summaries.

Test Plan

Saw a better summary of a list.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Don't trim remarkup corpora before summarizing.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 11 2015, 6:10 PM
This revision was automatically updated to reflect the committed changes.