Page MenuHomePhabricator

Fix excessively-conservative feed story policy checks
ClosedPublic

Authored by epriestley on May 9 2015, 5:53 PM.
Tags
None
Referenced Files
F13221506: D12785.diff
Sun, May 19, 2:49 AM
F13203901: D12785.diff
Wed, May 15, 12:12 AM
F13199939: D12785.id30747.diff
Mon, May 13, 8:18 PM
F13199938: D12785.id30733.diff
Mon, May 13, 8:18 PM
F13199917: D12785.id.diff
Mon, May 13, 8:13 PM
F13199871: D12785.diff
Mon, May 13, 7:39 PM
F13186541: D12785.diff
Sat, May 11, 3:42 AM
Unknown Object (File)
Tue, May 7, 6:59 AM

Details

Summary

When checking if a user can see a feed story about an object, we currently use the object's primary policy but ignore automatic capabilities.

Instead, proxy both primary policies and automatic capabilities.

Test Plan
  • Before this patch, users could not see stories about events they were invited to but not permitted to see by the primary policy (this is currently the default for newly created events).
  • After this patch, these invited users can now see the stories.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix excessively-conservative feed story policy checks.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: lpriestley.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 10 2015, 5:28 PM
This revision was automatically updated to reflect the committed changes.