Fixes T8102. This makes public rooms actually work. Also lets users see the search listings page so they can wander into all public rooms without logging in.
Details
Details
- Reviewers
epriestley chad - Maniphest Tasks
- T8102: Conpherence room with visibility set to "Public" requires login
- Commits
- Restricted Diffusion Commit
rPf309960a2d78: Conpherence - allow for public rooms to really work
As logged out user, visited ZXX and ZYY. ZXX was public, so I could see it and had a little "Login to Participate" button in the bottom. ZYY was not public so I was prompted to login. Back on ZXX I clicked the Conpherence crumb and got a sensible UI where most links prompted me to login. CLicked "search" and saw listings for all public rooms.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
One inline.
| src/applications/conpherence/controller/ConpherenceListController.php | ||
|---|---|---|
| 28–30 | I'd expect these to be shouldAllowPublic() instead. The difference between the two methods is subtle and should be better documented, but one case where they differ is that users with unverified email addresses can see !shouldRequireLogin() pages even if email verification is required on an install. They also have slightly different behavior for installs with policy.allow-public off. | |