Differential D12768

Calendar event detail view should show no time for all day events, and should show only one time field for one day events.
ClosedPublic
Actions

Authored by lpriestley on May 8 2015, 4:47 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8021: Implement "All Day" events

Commits

Restricted Diffusion Commit
rPda52a27b42c2: Calendar event detail view should show no time for all day events, and should…

Summary

Ref T8021, Calendar event detail view should show no time for all day events, and should show only one time field for one day events

Test Plan

Open all-day event, event should show "Time" field with not start/end dates. Two day events should show start and end days, not times. Normal events should show old way of displaying start and end times.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30691.May 8 2015, 4:47 AM

lpriestley retitled this revision from to Calendar event detail view should show no time for all day events, and should show only one time field for one day events..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8021: Implement "All Day" events.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 8 2015, 4:47 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Instead of figuring duration of all-day events, just compare if all-day event is a one-day or multi-day event to determine if should show start/end time or just one time.

epriestley accepted this revision.May 8 2015, 2:55 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 8 2015, 2:55 PM

Closed by commit rPda52a27b42c2: Calendar event detail view should show no time for all day events, and should… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 8 2015, 3:08 PM

This revision was automatically updated to reflect the committed changes.