Differential D12767

Calendar builtin queries should include a Day View
ClosedPublic
Actions

Authored by lpriestley on May 8 2015, 4:05 AM.

Tags

None

Referenced Files

	F15526126: D12767.id30686.diff
	Mon, Apr 21, 7:25 PM

	F15520770: D12767.id30686.diff
	Sun, Apr 20, 8:12 AM

	F15519828: D12767.id30686.diff
	Sat, Apr 19, 11:49 PM

	F15512902: D12767.id30689.diff
	Thu, Apr 17, 2:45 PM

	F15507196: D12767.diff
	Tue, Apr 15, 5:20 PM

	F15506159: D12767.id30689.diff
	Tue, Apr 15, 8:59 AM

	F15503969: D12767.id30686.diff
	Mon, Apr 14, 2:45 PM

	F15503688: D12767.id.diff
	Mon, Apr 14, 12:07 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T8108: Day view should be a saved query

Commits

Restricted Diffusion Commit
rP314dc5b9576b: Calendar builtin queries should include a Day View

Summary

Closes T8108, Calendar sidebar should include a Day View builtin query

Test Plan

Open Calendar, navigate to Day View in left sidebar, Day View with event preview should work as expected

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30686.May 8 2015, 4:05 AM

lpriestley retitled this revision from to Calendar builtin queries should include a Day View.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T8108: Day view should be a saved query.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 8 2015, 4:05 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

I think it would possibly be reasonable to make this the default (move it to the top) too, if you want.

This revision is now accepted and ready to land.May 8 2015, 4:15 AM

I think for now, I like the Month View as a default because Calendar has been historically more used for vacation days than meetings. I don't have too strong an opinion on this, so I could go either way. My inclination is to make Month default for now.

Closed by commit rP314dc5b9576b: Calendar builtin queries should include a Day View (authored by lpriestley, committed by lpriestley). · Explain WhyMay 8 2015, 4:18 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

query/

PhabricatorCalendarEventSearchEngine.php

3 lines

Diff 30689

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...