Differential D12765

Translate "All Day" events into the viewer's time
ClosedPublic
Actions

Authored by epriestley on May 8 2015, 1:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Feb 19, 12:35 AM

	Unknown Object (File)
	Thu, Feb 13, 9:14 PM

	Unknown Object (File)
	Sat, Feb 8, 4:24 AM

	Unknown Object (File)
	Sat, Feb 8, 4:24 AM

	Unknown Object (File)
	Sat, Feb 8, 4:24 AM

	Unknown Object (File)
	Sat, Feb 8, 3:21 AM

	Unknown Object (File)
	Mon, Feb 3, 3:32 AM

	Unknown Object (File)
	Thu, Jan 30, 3:11 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T8021: Implement "All Day" events

Commits

Restricted Diffusion Commit
rPf3d76a90f0e3: Translate "All Day" events into the viewer's time

Summary

Ref T8021.

When "All Day" events are loaded, convert them into the viewer's time.
When "All Day" events are saved, convert them into a +24 hour range.

Test Plan

Created and updated "All Day" events.
Created and updated normal events.
Changed timezones, edited and viewed "All Day" events and normal events.
In all cases, "All Day" events appeared to be 12:00AM - 11:59:59PM to the viewer, on the correct day.
Normal events shifted around properly according to timezones.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30683.May 8 2015, 1:27 AM

epriestley retitled this revision from to Translate "All Day" events into the viewer's time.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: lpriestley.

epriestley added a task: T8021: Implement "All Day" events.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 8 2015, 1:27 AM

lpriestley accepted this revision.May 8 2015, 1:57 AM

lpriestley edited edge metadata.

This revision is now accepted and ready to land.May 8 2015, 1:57 AM

Closed by commit rPf3d76a90f0e3: Translate "All Day" events into the viewer's time (authored by epriestley, committed by epriestley). · Explain WhyMay 8 2015, 1:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventEditController.php

15 lines

editor/

PhabricatorCalendarEventEditor.php

10 lines

query/

PhabricatorCalendarEventQuery.php

8 lines

storage/

PhabricatorCalendarEvent.php

100 lines

people/

storage/

PhabricatorUser.php

4 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

7 lines

Diff 30684

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/people/storage/PhabricatorUser.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...