Page MenuHomePhabricator
Differential D12743

Refactoring to use `PHUICalendarListView` instead of boxes
ClosedPublic
Actions

Authored by lpriestley on May 7 2015, 2:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 4:25 AM
Unknown Object (File)
Sat, Apr 20, 4:25 AM
Unknown Object (File)
Sat, Apr 20, 4:25 AM
Unknown Object (File)
Sat, Apr 20, 4:19 AM
Unknown Object (File)
Sat, Apr 20, 3:40 AM
Unknown Object (File)
Thu, Apr 11, 9:31 AM
Unknown Object (File)
Wed, Apr 10, 1:36 AM
Unknown Object (File)
Sun, Apr 7, 5:56 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Grey Medal" token, awarded by chad.

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4393: Implement "Daily/Weekly" Calendar Mock
Commits
Restricted Diffusion Commit
rP78438951c804: Refactoring to use `PHUICalendarListView` instead of boxes
Summary

Ref T4393, Refactoring to use PHUICalendarListView instead of boxes

Test Plan

See new sidebar

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30620.May 7 2015, 2:10 AM
lpriestley retitled this revision from to Refactoring to use `PHUICalendarListView` instead of boxes.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
lpriestley added a task: T4393: Implement "Daily/Weekly" Calendar Mock.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 7 2015, 2:10 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 7 2015, 2:11 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
392

Can we delete AphrontCalendarDayEventView now?

src/view/phui/calendar/PHUICalendarListView.php
110–113

No longer used.

This revision is now accepted and ready to land.May 7 2015, 2:11 AM
chad awarded a token.May 7 2015, 2:13 AM
lpriestley updated this revision to Diff 30621.May 7 2015, 2:14 AM
lpriestley edited edge metadata.

Deprecating AphrontCalendarDayEventView

lpriestley marked an inline comment as done.May 7 2015, 2:14 AM
lpriestley added a comment.EditedMay 7 2015, 2:18 AM

@chad, pretty sure either the PHUICalendarListView or PHUICalendarWidgetView has a fixed width, so that's why it's all smooshed up. Didn't touch the css, because I know you love it :)

Closed by commit rP78438951c804: Refactoring to use `PHUICalendarListView` instead of boxes (authored by lpriestley, committed by lpriestley). · Explain WhyMay 7 2015, 2:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
applications/
calendar/
query/
2 lines
view/
10 lines
view/
phui/
calendar/
108 lines
2 lines
webroot/
rsrc/
css/
phui/
calendar/
23 lines

Diff 30622

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Loading...
View Options

src/applications/calendar/view/AphrontCalendarDayEventView.php

Loading...
View Options

src/applications/calendar/view/AphrontCalendarEventView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-day.css

Loading...
Phabricator · Built by Phacility