Page MenuHomePhabricator

Refactor most uses of `AphrontFormDateControl` to user `AphrontFormDateControlValue`
ClosedPublic

Authored by lpriestley on May 6 2015, 1:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 22, 5:47 PM
Unknown Object (File)
Sun, Dec 15, 8:49 PM
Unknown Object (File)
Thu, Dec 12, 9:35 AM
Unknown Object (File)
Thu, Dec 12, 9:35 AM
Unknown Object (File)
Tue, Dec 3, 5:36 AM
Unknown Object (File)
Nov 27 2024, 10:01 AM
Unknown Object (File)
Nov 23 2024, 4:45 AM
Unknown Object (File)
Nov 19 2024, 8:44 AM
Subscribers

Details

Summary

Ref T8024, Refactor most uses of AphrontFormDateControl to user AphrontFormDateControlValue

Test Plan

Countdown and Phrequent should now save form data in error state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Refactor most uses of `AphrontFormDateControl` to user `AphrontFormDateControlValue`.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/countdown/controller/PhabricatorCountdownEditController.php
30

If you're feeling very ambitious, maybe call this something other than $initial_value since it's really just a general-purpose value.

This revision is now accepted and ready to land.May 6 2015, 2:02 AM
lpriestley edited edge metadata.

Changing initial_value to date_value to make it more generic.

This revision was automatically updated to reflect the committed changes.