Page MenuHomePhabricator
Differential D12731

Refactor most uses of `AphrontFormDateControl` to user `AphrontFormDateControlValue`
ClosedPublic
Actions

Authored by lpriestley on May 6 2015, 1:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 8:34 AM
Unknown Object (File)
Thu, Apr 25, 2:25 AM
Unknown Object (File)
Fri, Apr 19, 4:41 PM
Unknown Object (File)
Fri, Apr 19, 8:45 AM
Unknown Object (File)
Fri, Apr 19, 8:45 AM
Unknown Object (File)
Fri, Apr 19, 8:45 AM
Unknown Object (File)
Fri, Apr 19, 8:38 AM
Unknown Object (File)
Fri, Apr 19, 7:48 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8024: Update Calendar event date selection controls
Commits
Restricted Diffusion Commit
rP4cbdd0c6e903: Refactor most uses of `AphrontFormDateControl` to user…
Summary

Ref T8024, Refactor most uses of AphrontFormDateControl to user AphrontFormDateControlValue

Test Plan

Countdown and Phrequent should now save form data in error state.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30590.May 6 2015, 1:53 AM
lpriestley retitled this revision from to Refactor most uses of `AphrontFormDateControl` to user `AphrontFormDateControlValue`.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T8024: Update Calendar event date selection controls.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 6 2015, 1:53 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 6 2015, 2:02 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/countdown/controller/PhabricatorCountdownEditController.php
30

If you're feeling very ambitious, maybe call this something other than $initial_value since it's really just a general-purpose value.

This revision is now accepted and ready to land.May 6 2015, 2:02 AM
lpriestley updated this revision to Diff 30591.May 6 2015, 2:18 AM
lpriestley edited edge metadata.

Changing initial_value to date_value to make it more generic.

lpriestley marked an inline comment as done.May 6 2015, 2:18 AM
Closed by commit rP4cbdd0c6e903: Refactor most uses of `AphrontFormDateControl` to user… (authored by lpriestley, committed by lpriestley). · Explain WhyMay 6 2015, 2:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
countdown/
controller/
47 lines
phrequent/
controller/
41 lines
uiexample/
examples/

Diff 30592

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownEditController.php

Loading...
View Options

src/applications/phrequent/controller/PhrequentTrackController.php

Loading...
View Options

src/applications/uiexample/examples/PhabricatorFormUIExample.php

Loading...
Phabricator · Built by Phacility