Differential D12728

Restricting query to return the displayed range
ClosedPublic
Actions

Authored by lpriestley on May 5 2015, 10:45 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4393: Implement "Daily/Weekly" Calendar Mock

Commits

Restricted Diffusion Commit
rP88ef32f61cb9: Restricting query to return the displayed range

Summary

Ref T4393, Refactoring calendar query logic to only return at most what the query dates have specified

Test Plan

Query Calendar events for range May 1 - indefinite in month view, see events, scroll back to April, events should be absent, because April is out of range.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30580.May 5 2015, 10:45 PM

lpriestley retitled this revision from to Restricting query to return the displayed range.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T4393: Implement "Daily/Weekly" Calendar Mock.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 5 2015, 10:45 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 5 2015, 10:50 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php
66	Extra space at the end of this string.

This revision is now accepted and ready to land.May 5 2015, 10:50 PM

extra space.

Closed by commit rP88ef32f61cb9: Restricting query to return the displayed range (authored by lpriestley, committed by lpriestley). · Explain WhyMay 5 2015, 11:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

query/

PhabricatorCalendarEventSearchEngine.php

40 lines

Diff 30586

View Options

src/applications/calendar/query/PhabricatorCalendarEventSearchEngine.php

Restricting query to return the displayed rangeClosedPublicActions