FIFOs are often created by shells, or other programmatic things
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers
ran arc unit
also tested that arc diff --create -F <(echo foo) works. <(echo foo) creates a named pipe
Diff Detail
Diff Detail
- Repository
- rPHU libphutil
- Branch
- master
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5780 Build 5799: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Keep in mind that you can't seek in FIFOs, and that the paths asserted to be files may be passed into other external utilities (such as during linting or unit testing).
Comment Actions
I considered that case, but I think cases where seeking matters less. It may be better for me to implement a new function isReadableObject or the like which permits a FIFO, file, (or even others) and use it instead.
It is certainly correct for me up to update the documentation in either case.
I'll leave it up to @epriestley which he prefers, and I'll do that
Comment Actions
Per T8079 and discussion on IRC, I'm not interested in bringing this to the upstream.