Page MenuHomePhabricator

Where files are allowed, also permit FIFOs which act very similarly
AbandonedPublic

Authored by eadler on May 5 2015, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 9:40 AM
Unknown Object (File)
Thu, Apr 25, 3:21 AM
Unknown Object (File)
Wed, Apr 17, 2:15 PM
Unknown Object (File)
Mar 30 2024, 5:32 PM
Unknown Object (File)
Mar 24 2024, 8:53 PM
Unknown Object (File)
Mar 20 2024, 10:08 PM
Unknown Object (File)
Mar 16 2024, 6:46 PM
Unknown Object (File)
Mar 13 2024, 8:37 PM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

FIFOs are often created by shells, or other programmatic things

Test Plan

ran arc unit
also tested that arc diff --create -F <(echo foo) works. <(echo foo) creates a named pipe

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5780
Build 5799: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

eadler retitled this revision from to Where files are allowed, also permit FIFOs which act very similarly.
eadler updated this object.
eadler edited the test plan for this revision. (Show Details)
eadler added a reviewer: epriestley.
eadler edited edge metadata.

Keep in mind that you can't seek in FIFOs, and that the paths asserted to be files may be passed into other external utilities (such as during linting or unit testing).

I considered that case, but I think cases where seeking matters less. It may be better for me to implement a new function isReadableObject or the like which permits a FIFO, file, (or even others) and use it instead.

It is certainly correct for me up to update the documentation in either case.

I'll leave it up to @epriestley which he prefers, and I'll do that

epriestley edited edge metadata.

Per T8079 and discussion on IRC, I'm not interested in bringing this to the upstream.

This revision now requires changes to proceed.May 14 2015, 1:32 PM