Differential D12719

Conpherence - use new getDisplayTitle for search results
ClosedPublic
Actions

Authored by btrahan on May 5 2015, 5:33 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T8066: Check my Conpherence title/handle fix

Commits

Restricted Diffusion Commit
rPcebf4598657a: Conpherence - use new getDisplayTitle for search results

Summary

Fixes T8066. These search results were using getDisplayData but only need a title. Use more granular API introduced in rPf311f3f910e31b72345e37bf2e5bea0f278fd111.

Test Plan

ran a conpherence query for messages and no more fatal

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 30559.May 5 2015, 5:33 PM

btrahan retitled this revision from to Conpherence - use new getDisplayTitle for search results.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a task: T8066: Check my Conpherence title/handle fix.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 5 2015, 5:33 PM

epriestley accepted this revision.May 5 2015, 5:34 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 5 2015, 5:34 PM

Closed by commit rPcebf4598657a: Conpherence - use new getDisplayTitle for search results (authored by btrahan, committed by btrahan). · Explain WhyMay 5 2015, 5:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

query/

ConpherenceThreadSearchEngine.php

3 lines

Diff 30560

View Options

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Conpherence - use new getDisplayTitle for search resultsClosedPublicActions