Paths

Table of Contentst

Fix two global search issues
ClosedPublic
Actions

Authored by epriestley on May 4 2015, 11:35 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T8016: Exception using search: "Invalid UTF-8 string passed to phutil_utf8v()"

Commits

Restricted Diffusion Commit
rPc5a734073d24: Fix two global search issues

Summary

Fixes T8016.

Don't explode on bad UTF8, if we happen to get some for whatever reason.
Don't put <strong> tags in the "title" attribute.

Test Plan

Faked bad UTF8, no fatal. Hovered titles, no <strong> tags.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30524.May 4 2015, 11:35 PM

epriestley retitled this revision from to Fix two global search issues.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8016: Exception using search: "Invalid UTF-8 string passed to phutil_utf8v()".

Herald added a subscriber: epriestley. · View Herald TranscriptMay 4 2015, 11:35 PM

chad accepted this revision.May 5 2015, 1:33 AM

chad added a reviewer: chad.

This revision is now accepted and ready to land.May 5 2015, 1:33 AM

Closed by commit rPc5a734073d24: Fix two global search issues (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2015, 1:34 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

view/

PhabricatorSearchResultView.php

9 lines

view/

phui/

PHUIObjectItemView.php

19 lines

Diff 30525

View Options

src/applications/search/view/PhabricatorSearchResultView.php