Differential D12675

Support sampling subprocess execution in Multimeter
ClosedPublic
Actions

Authored by epriestley on May 3 2015, 5:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 27, 9:22 PM

	Unknown Object (File)
	Nov 20 2024, 3:34 PM

	Unknown Object (File)
	Nov 15 2024, 5:56 PM

	Unknown Object (File)
	Nov 12 2024, 2:38 AM

	Unknown Object (File)
	Nov 8 2024, 2:05 PM

	Unknown Object (File)
	Oct 29 2024, 3:05 PM

	Unknown Object (File)
	Oct 20 2024, 1:04 AM

	Unknown Object (File)
	Oct 18 2024, 10:31 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T6930: Build Multimeter, a "why is Phabricator slow?" toolset

Commits

Restricted Diffusion Commit
rPbee4dc7d5316: Support sampling subprocess execution in Multimeter

Summary

Ref T6930. Add subprocess sampling/labeling.

Test Plan

(This table includes some buggy test labels.)

Screen Shot 2015-05-03 at 10.23.57 AM.png (1×1 px, 249 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30440.May 3 2015, 5:24 PM

epriestley retitled this revision from to Support sampling subprocess execution in Multimeter.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T6930: Build Multimeter, a "why is Phabricator slow?" toolset.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 3 2015, 5:24 PM

btrahan accepted this revision.May 4 2015, 4:54 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/multimeter/data/MultimeterControl.php
236–239	Seems like a good idea for now, though I predict we'll at least need to grow this list a bit over time.

This revision is now accepted and ready to land.May 4 2015, 4:54 PM

btrahan added inline comments.May 4 2015, 4:55 PM

src/applications/multimeter/data/MultimeterControl.php
236–239	maybe we just end up with some conf dict that gets merged in? we can then have admins mess with the conf if we're looking for specific performance issues to get sampled in all their glory.

Since we don't actually use the table until the very end of the request, we could let third-party applications do this sort of thing:

$multimeter = ...
$multimeter->addCommandAbbreviationConfig(...);

...once we run into it in the wild.

Closed by commit rPbee4dc7d5316: Support sampling subprocess execution in Multimeter (authored by epriestley, committed by epriestley). · Explain WhyMay 4 2015, 5:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

multimeter/

data/

MultimeterControl.php

87 lines

storage/

MultimeterEvent.php

4 lines

Diff 30486

src/applications/multimeter/data/MultimeterControl.php

Loading...

src/applications/multimeter/storage/MultimeterEvent.php

Loading...