Page MenuHomePhabricator
Differential D12649

Projects - publish feed stories for project edits
ClosedPublic
Actions

Authored by btrahan on May 1 2015, 11:31 PM.
Tags
None
Referenced Files
F14015284: D12649.id.diff
Sun, Nov 3, 5:04 PM
F13998109: D12649.id30387.diff
Thu, Oct 24, 7:37 AM
F13984474: D12649.id30386.diff
Sun, Oct 20, 1:38 PM
F13976932: D12649.id30388.diff
Fri, Oct 18, 4:21 PM
F13975696: D12649.id.diff
Fri, Oct 18, 11:14 AM
F13975456: D12649.diff
Fri, Oct 18, 10:12 AM
F13965769: D12649.id30389.diff
Wed, Oct 16, 4:11 AM
F13960598: D12649.id.diff
Tue, Oct 15, 12:15 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Mountain of Wealth" token, awarded by chad.

Details

Reviewers
epriestley
Maniphest Tasks
T7426: Creating a new project does not publish a feed story
Commits
Restricted Diffusion Commit
rP7aac1effacc6: Projects - publish feed stories for project edits
Summary

Fixes T7426. Wasn't 100% sure what the right feed notify phids were so I went with project subscribers.

Test Plan

made a project and saw the "btrahan created $project" story. edited project members and hashtags and got proper stories.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 30384.May 1 2015, 11:31 PM
btrahan added a task: T7426: Creating a new project does not publish a feed story.
btrahan retitled this revision from to Projects - publish feed stories for project edits.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 1 2015, 11:31 PM
chad awarded a token.May 1 2015, 11:33 PM
epriestley accepted this revision.May 2 2015, 12:01 AM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
412–419

I think this is redundant since Subscribers should put them in CC and the default is "To + Cc".

This revision is now accepted and ready to land.May 2 2015, 12:01 AM
btrahan updated this revision to Diff 30386.May 2 2015, 12:32 AM
btrahan edited edge metadata.

implement getMailTo (just return array()) so default getFeedNotifyPHIDs works

btrahan updated this revision to Diff 30387.May 2 2015, 12:33 AM

fix getMailTo signature (protected => public)

btrahan updated this revision to Diff 30388.May 2 2015, 12:34 AM

really get the signature right

Closed by commit rP7aac1effacc6: Projects - publish feed stories for project edits (authored by btrahan, committed by btrahan). · Explain WhyMay 2 2015, 12:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
controller/
12 lines
editor/
13 lines
storage/
119 lines
infrastructure/
internationalization/
translation/
34 lines

Diff 30389

View Options

src/applications/project/controller/PhabricatorProjectEditDetailsController.php

Loading...
View Options

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectTransaction.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility