Page MenuHomePhabricator

Minor tweaks to inline comments
ClosedPublic

Authored by chad on May 1 2015, 4:52 AM.

Details

Summary

Ref T7447, Ref T1460. Moves "done" state to left, and no longer is a button (simpler CSS). Also feels a little nicer. Clean up some spacing issue with Ghosties.

Test Plan

Test new and old comments, as author and reviewer.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 30354.May 1 2015, 4:52 AM
chad retitled this revision from to Minor tweaks to inline comments.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad edited the test plan for this revision. (Show Details)May 1 2015, 4:54 AM
chad updated this revision to Diff 30355.May 1 2015, 5:22 AM
  • remove periods
aik099 added a subscriber: aik099.May 1 2015, 7:06 AM

What is ghost inline comments?

epriestley accepted this revision.May 1 2015, 12:29 PM
epriestley edited edge metadata.

See T7447 for a discussion of "ghosts" inlines.

This revision is now accepted and ready to land.May 1 2015, 12:29 PM
This revision was automatically updated to reflect the committed changes.