Page MenuHomePhabricator

Calendar events should support comments
ClosedPublic

Authored by lpriestley on May 1 2015, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 12, 8:51 PM
Unknown Object (File)
Wed, Nov 27, 3:20 PM
Unknown Object (File)
Nov 19 2024, 1:36 AM
Unknown Object (File)
Nov 12 2024, 7:30 AM
Unknown Object (File)
Oct 23 2024, 3:41 PM
Unknown Object (File)
Oct 19 2024, 10:12 PM
Unknown Object (File)
Oct 15 2024, 9:29 PM
Unknown Object (File)
Oct 11 2024, 10:05 PM
Subscribers

Details

Summary

Closes T7956, Calendar events should support comments.

Test Plan

Open event, add comment, save, comment should appear in timeline.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Calendar events should support comments.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley edited edge metadata.

Use getMonogram!

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/application/PhabricatorCalendarApplication.php
59

indent for consistncyreys

src/applications/calendar/controller/PhabricatorCalendarEventCommentController.php
7–14

Consider modernizing to use handleRequest(AphrontRequest $request) instead.

11

Stray debugging code.

This revision is now accepted and ready to land.May 1 2015, 12:31 AM
lpriestley marked 3 inline comments as done.
lpriestley edited edge metadata.

Considered modernizing it.

This revision was automatically updated to reflect the committed changes.