Page MenuHomePhabricator

Fix calendar z-index and Conpherence/Calendar integration
ClosedPublic

Authored by epriestley on May 1 2015, 12:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 13, 3:41 PM
Unknown Object (File)
Thu, Jan 2, 2:06 PM
Unknown Object (File)
Tue, Dec 24, 1:04 PM
Unknown Object (File)
Dec 13 2024, 10:25 PM
Unknown Object (File)
Dec 12 2024, 8:25 PM
Unknown Object (File)
Dec 3 2024, 10:57 PM
Unknown Object (File)
Dec 3 2024, 10:57 PM
Unknown Object (File)
Dec 3 2024, 10:56 PM
Subscribers
Tokens
"Haypence" token, awarded by lpriestley.

Details

Summary

Fixes T7975. Long ago, this element looked like this when you expanded it:

+-------------------+
|     3 4 5 6 7   X |
| 8 9 1 2 3 4 5 +---+
| 6 7 8 9 1 2 3 |
| 4 5 6 7       |
+---------------+

That was why the icon needed a z-index. See T5880. @chad fixed this a while ago so it looks like this:

+---------------+
|     3 4 5 6 7 | X
| 8 9 1 2 3 4 5 |
| 6 7 8 9 1 2 3 |
| 4 5 6 7       |
+---------------+

...but we never stripped the z-index off, causing the bug in T7975.

Also fix some collateral damage from the recent calendar refactoring and the Conpherence widget.

Test Plan
  • Created a new event via Conpherence
  • Created a new event normally.
  • Browsed a typeahead in Calendar without icons showing through.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix calendar z-index and Conpherence/Calendar integration.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad, lpriestley.
epriestley added a subscriber: chad.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/calendar/controller/PhabricatorCalendarEventEditController.php
76

getMonogram maybs?

This revision is now accepted and ready to land.May 1 2015, 12:07 AM
epriestley edited edge metadata.
  • Use getMonogram().
This revision was automatically updated to reflect the committed changes.