Differential D12629

Adding official Feed stories for Calendar event invite/uninvite actions
ClosedPublic
Actions

Authored by lpriestley on Apr 30 2015, 7:13 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 28, 11:14 AM

	Unknown Object (File)
	Mon, Jan 27, 11:41 PM

	Unknown Object (File)
	Fri, Jan 24, 3:37 AM

	Unknown Object (File)
	Fri, Jan 24, 3:37 AM

	Unknown Object (File)
	Fri, Jan 24, 3:37 AM

	Unknown Object (File)
	Fri, Jan 24, 3:37 AM

	Unknown Object (File)
	Sun, Jan 19, 3:53 PM

	Unknown Object (File)
	Sat, Jan 18, 1:22 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7988: Create meaningful transaction messages

Commits

Restricted Diffusion Commit
rP47f91c322da9: Adding official Feed stories for Calendar event invite/uninvite actions

Summary

Closes T7988, Adding official Feed stories for Calendar event invite/uninvite actions.

Test Plan

Invite/uninvite users to Calendar events, save, go to Feed, inspect stories.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30322.Apr 30 2015, 7:13 PM

lpriestley retitled this revision from to Adding official Feed stories for Calendar event invite/uninvite actions.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7988: Create meaningful transaction messages.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 30 2015, 7:13 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 30 2015, 7:28 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
325–331	At some point we might want to just hide these from feed/notifications/etc, since they're pretty uninteresting and vaguely sketchy to publish/distribute, maybe.

This revision is now accepted and ready to land.Apr 30 2015, 7:28 PM

lpriestley added inline comments.Apr 30 2015, 7:29 PM

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
325–331	Do you think we should do that out of the gate? Or try them out and get some feedback?

Trying them out seems fine to me.

Closed by commit rP47f91c322da9: Adding official Feed stories for Calendar event invite/uninvite actions (authored by lpriestley, committed by lpriestley). · Explain WhyApr 30 2015, 7:34 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

storage/

PhabricatorCalendarEventTransaction.php

107 lines

Diff 30324

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...