Page MenuHomePhabricator

Collapse previous/forward by default, click to expand.
ClosedPublic

Authored by chad on Apr 30 2015, 6:03 PM.
Tags
None
Referenced Files
F14005720: D12627.diff
Sun, Oct 27, 6:16 PM
F13995586: D12627.id30316.diff
Wed, Oct 23, 2:05 PM
F13980256: D12627.id30319.diff
Oct 19 2024, 9:22 AM
F13961813: D12627.id30317.diff
Oct 15 2024, 6:29 AM
Unknown Object (File)
Sep 21 2024, 5:04 AM
Unknown Object (File)
Sep 14 2024, 7:28 AM
Unknown Object (File)
Sep 14 2024, 7:28 AM
Unknown Object (File)
Sep 14 2024, 7:24 AM
Subscribers

Details

Summary

This is a lighter UI treatment for previous/forward comments, where the comment is just hidden behind a click. This mayyy be too hard to discover, but I'd rather wait and make it more obvious if actually needed. Once you understand the interaction, the cleaner UI is preferable. Ref T7447

Test Plan

Test a lot of previous and forward comments.

Screen Shot 2015-04-30 at 11.06.29 AM.png (850×1 px, 279 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Collapse previous/forward by default, click to expand..
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
  • Use fast-forward and fast-backword
chad added inline comments.
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
427

whoopsies

epriestley edited edge metadata.

I'm personally quite happy with things as they are, but this is easier than some of the other suggestions, so let's see how it works.

This revision is now accepted and ready to land.Apr 30 2015, 6:17 PM
This revision was automatically updated to reflect the committed changes.
chad marked an inline comment as done.Apr 30 2015, 8:53 PM

After using these, I've literally clicked every single one of these I've hit. I never remember what they said and always want to read them.

Maybe we should add a preference?

  • Show Full
  • Show Collapsed (Default)
  • Hide

I hate adding preferences, but this feature was like 10x better for me before the collapse change.

I can try to get summarizing kind of working before we go that far, I just think it's going to be junk in a bunch of cases. Not sure if that will be 2% of cases or 35%.

I'd remove the collapse and just make a JS toggle / pref. show old / hide old. I don't mind preferences when I feel people are going to be opinionated on both sides and we want everyone to feel productive.

Probably still keep some icon indication ghost comments exist though even if you have them off?

That seems reasonable, but might be tricky to implement.

What can I do here for next steps then?

  • Remove 'minimal UI'
  • Add keyboard shortcut to toggle ghost on and off
  • Add sticky preference (or settings preference?)
  • Add UI hint that old comments exist

I can do some of these, just didn't know if you were also working on them.

Let me try to do summaries first and see how bad that actually is, I really hate preferences.

If that route, probably also open them all with one click instead of individual. Like, you either want to read it all or just have a small summary.

This isn't really even close in a bunch of cases:

Screen Shot 2015-05-01 at 3.45.10 PM.png (327×725 px, 63 KB)

Yeah I faked it by just pulling up the text from the first p tag, and hiding everything else.