Page MenuHomePhabricator

Calendar events should now auto-invite the creator
ClosedPublic

Authored by lpriestley on Apr 29 2015, 8:12 PM.
Tags
None
Referenced Files
F14080578: D12613.id30286.diff
Fri, Nov 22, 3:05 PM
Unknown Object (File)
Wed, Nov 20, 8:27 PM
Unknown Object (File)
Sun, Nov 17, 4:13 PM
Unknown Object (File)
Sun, Nov 17, 4:13 PM
Unknown Object (File)
Sun, Nov 17, 4:13 PM
Unknown Object (File)
Sat, Nov 16, 9:03 AM
Unknown Object (File)
Thu, Nov 14, 4:35 AM
Unknown Object (File)
Tue, Nov 12, 11:59 PM
Subscribers

Details

Summary

Closes T7935, Calendar events should now auto-invite the creator.

Test Plan

Create event, save, event should now show creator as an invitee.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Calendar events should now auto-invite the creator.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley edited edge metadata.

Removing commented out code.

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/calendar/query/PhabricatorCalendarEventInviteeQuery.php
56

Minor, but prefer to check these strictly against null, e.g.:

if ($this->ids !== null) { ... }

This prevents a bug where callers do:

->withIDs(array())

...by mistake and accidentally select every result.

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
303–305

This might be worth breaking out separately at some point since I could imagine a user caring about the event getting rescheduled but not caring about the invitee list changing. Perfectly fine for now, though.

This revision is now accepted and ready to land.Apr 29 2015, 8:36 PM
lpriestley edited edge metadata.

Checking strictly null.

src/applications/calendar/query/PhabricatorCalendarEventInviteeQuery.php
63–89

Oh, sorry, for all of these cases.

This revision was automatically updated to reflect the committed changes.