Closes T7946, CalenderEvent implement PhabricatorTokenReceiverInterface.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7946: Implement PhabricatorTokenReceiverInterface on CalendarEvent
- Commits
- Restricted Diffusion Commit
rP15310bbcdf48: CalendarEvent implements PhabricatorTokenReceiverInterface
Create or open a calendar event, award a token, rescind the token, see the full timeline under the event details, open Feed, only token award action should have surfaced.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| src/applications/calendar/storage/PhabricatorCalendarEvent.php | ||
|---|---|---|
| 243–247 | It's sufficient to just return array($this->getUserPHID()). array_unique() removes duplicates, but the list only has one item so it certainly can't contain duplicates. array_filter() removes empty/null values. It's possible that an event might not have a userPHID if someone has messed up the database, but it should never normally happen. It's OK to return questionable data in weird edge cases if someone messed with the database. | |