For loadContextMessages, there's a similar problem (the last bits of T7757) but for just a single thread when we need to load something like ZX#YYYY. We need to get the YYYY transaction, a few transactions prior (a few to render plus enough to know if we need a "show older" ui element), and then a standard ish amount of transactions after. (Note we need new "show newer" technology for corner cases where we don't load to the latest.) Anyway, I think this other problem is just solved with two simple queries around YYYY, but bringing it up now just in case.

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php
280–281	I think the possible hole here is if people search for very common words. ...but I agree it seems wildly unlikely in practical terms so whatevs. :D

This revision is now accepted and ready to land.Apr 28 2015, 6:28 PM

Yeah, I think the before + after method is a lot simpler but would cost us like 600 queries per page in the worst case here (100 results * 3 snippets * 2 queries). This is kind of more complex than I'd anticipated, but shouldn't cost very much (average of slightly more than 3 queries -- get-context, get-next-transactions, load-transactions -- hopefully).

Closed by commit rPcd7fec1729fe: Implement very rough message context for Conpherence search (authored by epriestley, committed by epriestley). · Explain WhyApr 28 2015, 6:44 PM

This revision was automatically updated to reflect the committed changes.