Page MenuHomePhabricator

Quicksand - get the dark console working properly with quicksand
ClosedPublic

Authored by btrahan on Apr 27 2015, 11:04 PM.
Tags
None
Referenced Files
F13998189: D12582.id.diff
Thu, Oct 24, 8:01 AM
F13993646: D12582.id30210.diff
Wed, Oct 23, 12:24 AM
Unknown Object (File)
Oct 7 2024, 10:53 PM
Unknown Object (File)
Sep 27 2024, 1:38 PM
Unknown Object (File)
Sep 23 2024, 12:38 AM
Unknown Object (File)
Sep 21 2024, 7:03 PM
Unknown Object (File)
Sep 17 2024, 8:07 AM
Unknown Object (File)
Sep 12 2024, 7:04 AM
Subscribers

Details

Summary

Fixes T7700.

This ends up being kind of tricky because

  • the key for a given request is only correct at the time the dark console is rendered
  • the dark console itself should contain every request made, as opposed to being drawn from scratch
  • in the case of a quicksand request, the behavior gets invoked first with the correctly rendered console as part of the quicksand-redraw event and then again shortly after as an ajax request would, except this is incorrect relative to when the key should be calculated...

So...

  • assume we can get away with concurrency between the quicksand-redraw event and ajax request invocation of the behavior
  • cache the right data as part of the quicksand-redraw event and then use it in the subsequent ajax call
    • make sure ajax config gets a 'quicksand' flag

...otherwise its somewhat standard make sure this behavior can be init'd a bunch stuff.

Test Plan

visited '/', visited '/differential/', visited '/DXXX' - observed correctly populating dark console with all sorts of good data stuff. navigated backwards and observed dark console staying the same as expected. navigated by clicking links and console updated again

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Quicksand - get the dark console working properly with quicksand.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Nice, this works great!

This revision is now accepted and ready to land.Apr 27 2015, 11:08 PM
This revision was automatically updated to reflect the committed changes.