Page MenuHomePhabricator
Differential D12540

Update the search scope selector after Quicksand navigation
ClosedPublic
Actions

Authored by epriestley on Apr 24 2015, 5:42 PM.
Tags
None
Referenced Files
F14006705: D12540.id.diff
Mon, Oct 28, 3:40 PM
F14003938: D12540.diff
Sat, Oct 26, 1:12 PM
Unknown Object (File)
Oct 13 2024, 10:49 AM
Unknown Object (File)
Oct 13 2024, 6:51 AM
Unknown Object (File)
Oct 5 2024, 8:53 AM
Unknown Object (File)
Sep 27 2024, 2:15 PM
Unknown Object (File)
Sep 27 2024, 2:13 PM
Unknown Object (File)
Sep 27 2024, 2:12 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7900: Update search scope selector for Quicksand navigation
Commits
Restricted Diffusion Commit
rP0b309b6193d9: Update the search scope selector after Quicksand navigation
Summary

Fixes T7900.

  • Update the hidden form input so the current application is searched.
  • Update the menu icon.
  • Update the button icon, if "Search Current Application" is selected.
Test Plan
  • Navigated between applications with Quicksand.
    • Observed button icon update.
    • Observed menu icon update.
    • Observed results being scoped to the correct application.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30113.Apr 24 2015, 5:42 PM
epriestley retitled this revision from to Update the search scope selector after Quicksand navigation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7900: Update search scope selector for Quicksand navigation.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 24 2015, 5:42 PM
epriestley added inline comments.Apr 24 2015, 5:43 PM
webroot/rsrc/js/core/behavior-global-drag-and-drop.js
101–102

Pretty sure this wasn't doing anything intentionally.

btrahan accepted this revision.Apr 24 2015, 8:57 PM
btrahan edited edge metadata.
btrahan added inline comments.
webroot/rsrc/js/core/behavior-global-drag-and-drop.js
101–102

copy paste fo' sho'

This revision is now accepted and ready to land.Apr 24 2015, 8:57 PM
Closed by commit rP0b309b6193d9: Update the search scope selector after Quicksand navigation (authored by epriestley, committed by epriestley). · Explain WhyApr 24 2015, 9:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
36 lines
src/
view/
page/
15 lines
menu/
26 lines
webroot/
rsrc/
js/
core/
2 lines
53 lines

Diff 30124

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

Loading...
View Options

webroot/rsrc/js/core/behavior-global-drag-and-drop.js

Loading...
View Options

webroot/rsrc/js/core/behavior-search-typeahead.js

Loading...
Phabricator · Built by Phacility