Page MenuHomePhabricator

Update the search scope selector after Quicksand navigation
ClosedPublic

Authored by epriestley on Apr 24 2015, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 3:06 AM
Unknown Object (File)
Fri, Jan 24, 3:06 AM
Unknown Object (File)
Fri, Jan 24, 3:06 AM
Unknown Object (File)
Fri, Jan 24, 3:05 AM
Unknown Object (File)
Tue, Jan 21, 10:30 AM
Unknown Object (File)
Fri, Jan 17, 7:54 PM
Unknown Object (File)
Sun, Jan 12, 9:23 PM
Unknown Object (File)
Dec 19 2024, 7:16 AM
Subscribers

Details

Summary

Fixes T7900.

  • Update the hidden form input so the current application is searched.
  • Update the menu icon.
  • Update the button icon, if "Search Current Application" is selected.
Test Plan
  • Navigated between applications with Quicksand.
    • Observed button icon update.
    • Observed menu icon update.
    • Observed results being scoped to the correct application.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Update the search scope selector after Quicksand navigation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
webroot/rsrc/js/core/behavior-global-drag-and-drop.js
101–102

Pretty sure this wasn't doing anything intentionally.

btrahan edited edge metadata.
btrahan added inline comments.
webroot/rsrc/js/core/behavior-global-drag-and-drop.js
101–102

copy paste fo' sho'

This revision is now accepted and ready to land.Apr 24 2015, 8:57 PM
This revision was automatically updated to reflect the committed changes.