Page MenuHomePhabricator

Quicksand - make things work properly with high security mode
ClosedPublic

Authored by btrahan on Apr 23 2015, 11:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 14 2024, 1:41 PM
Unknown Object (File)
Feb 14 2024, 1:41 PM
Unknown Object (File)
Feb 14 2024, 1:33 PM
Unknown Object (File)
Feb 14 2024, 1:33 PM
Unknown Object (File)
Feb 10 2024, 1:11 AM
Unknown Object (File)
Feb 7 2024, 6:59 PM
Unknown Object (File)
Feb 7 2024, 4:01 PM
Unknown Object (File)
Feb 4 2024, 4:55 PM
Subscribers

Details

Summary

Fixes T7064. We need to pass the quicksand magic request variable around and then instrument the javascript to handle quicksand page loads.

Test Plan

Enabled two factor auth on my account and then

  • visited password page
  • filled out 2 factor auth request
  • saw high security bubble
  • clicked about still seeing high security bubble
  • refreshed page and still saw security bubble
  • dismissed bubble by following through workflow after clicking bubble

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Quicksand - make things work properly with high security mode.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/js/core/behavior-high-security-warning.js
39

Maybe this should return if it isn't a fresh response, like how notifications work?

This revision is now accepted and ready to land.Apr 23 2015, 11:35 PM
btrahan edited edge metadata.

Dont update hi sec if the response isn't from the server. Handles the case where hi sec -> not hi sec -> user hits back to the hi sec stuff.

This revision was automatically updated to reflect the committed changes.