Fixes T7064. We need to pass the quicksand magic request variable around and then instrument the javascript to handle quicksand page loads.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T7064: Hi-Sec doesn't work properly with Quicksand
- Commits
- Restricted Diffusion Commit
rPa903eb2defb6: Quicksand - make things work properly with high security mode
Enabled two factor auth on my account and then
- visited password page
- filled out 2 factor auth request
- saw high security bubble
- clicked about still seeing high security bubble
- refreshed page and still saw security bubble
- dismissed bubble by following through workflow after clicking bubble
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| webroot/rsrc/js/core/behavior-high-security-warning.js | ||
|---|---|---|
| 39 | Maybe this should return if it isn't a fresh response, like how notifications work? | |
Comment Actions
Dont update hi sec if the response isn't from the server. Handles the case where hi sec -> not hi sec -> user hits back to the hi sec stuff.