Differential D12507

Conpherence - sort participant list in a case insensitive way
ClosedPublic
Actions

Authored by btrahan on Apr 22 2015, 7:02 PM.

Tags

None

Referenced Files

	F14028756: D12507.id30033.diff
	Fri, Nov 8, 3:33 PM

	F14028459: D12507.id30033.diff
	Fri, Nov 8, 1:19 PM

	F14006678: D12507.id30028.diff
	Mon, Oct 28, 3:09 PM

	F13977002: D12507.id.diff
	Oct 18 2024, 4:43 PM

	F13970678: D12507.id30033.diff
	Oct 17 2024, 9:15 AM

	Unknown Object (File)
	Sep 6 2024, 9:09 AM

	Unknown Object (File)
	Aug 26 2024, 2:57 AM

	Unknown Object (File)
	Aug 25 2024, 5:33 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7857: Conpherence participants are sorted by alpha, but with capital letters first

Commits

Restricted Diffusion Commit
rP2e8649c29231: Conpherence - sort participant list in a case insensitive way

Summary

Fixes T7857. Some sorting gymnastics - make a nice list for natcasesort and then array_select_key to sort - but nothing too crazy.

Test Plan

made a room with user "btrahan" and other users "BTRAHA", "BTRAHANCAPS", and "xerxes". chat room correctly ordered "btrahan" (since logged in user always at top), "BTRAHA", "BTRAHANCAPS", "xerxes". Viewed room as "xerxes" and saw ordering "xerxes", "BTRAHA", "btrahan", "BTRAHANCAPS".

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 30028.Apr 22 2015, 7:02 PM

btrahan added a task: T7857: Conpherence participants are sorted by alpha, but with capital letters first.

btrahan retitled this revision from to Conpherence - sort participant list in a case insensitive way.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 22 2015, 7:02 PM

epriestley accepted this revision.Apr 22 2015, 7:12 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 22 2015, 7:12 PM

Closed by commit rP2e8649c29231: Conpherence - sort participant list in a case insensitive way (authored by btrahan, committed by btrahan). · Explain WhyApr 22 2015, 7:19 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

view/

ConpherencePeopleWidgetView.php

11 lines

Diff 30033

src/applications/conpherence/view/ConpherencePeopleWidgetView.php

Loading...