Add a "remove projects" action to Herald
ClosedPublic
Actions

Authored by epriestley on Apr 22 2015, 12:21 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions

Commits

Restricted Diffusion Commit
rPd8b4f32d04a2: Add a "remove projects" action to Herald

Summary

Fixes T7849. This adds "Remove Projects" to all objects which implement PhabricatorProjectInterface.

Test Plan

Wrote a rule to remove a project, edited task, saw the project removed.
Admired entirely reasonable implementation complexity.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30025.Apr 22 2015, 12:21 PM

epriestley retitled this revision from to Add a "remove projects" action to Herald.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7849: Allow herald rules to remove a project in HeraldManiphestTaskAdapter Actions.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 22 2015, 12:21 PM

btrahan accepted this revision.Apr 22 2015, 5:32 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 22 2015, 5:32 PM

Closed by commit rPd8b4f32d04a2: Add a "remove projects" action to Herald (authored by epriestley, committed by epriestley). · Explain WhyApr 22 2015, 9:01 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

13 lines

Diff 30040

View Options

src/applications/herald/adapter/HeraldAdapter.php

Add a "remove projects" action to HeraldClosedPublicActions