Page MenuHomePhabricator

Merge redundant Herald effect code
ClosedPublic

Authored by epriestley on Apr 22 2015, 11:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 10:27 AM
Unknown Object (File)
Thu, Apr 11, 9:33 AM
Unknown Object (File)
Tue, Apr 9, 10:48 AM
Unknown Object (File)
Fri, Mar 29, 10:57 PM
Unknown Object (File)
Fri, Mar 29, 4:19 PM
Unknown Object (File)
Feb 27 2024, 9:03 PM
Unknown Object (File)
Feb 27 2024, 8:58 PM
Unknown Object (File)
Feb 27 2024, 8:58 PM
Subscribers

Details

Summary

Ref T7849. Lift more action handling out of adapters. In theory, adapters will some day do no action handling. That day is not today, but it is now a step closer.

Test Plan
  • Wrote a rule using the email and flag actions.
  • Ran that rule.
  • Got an email and flag.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Merge redundant Herald effect code.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 22 2015, 5:30 PM
This revision was automatically updated to reflect the committed changes.