Simplify timeline rendering on Differential revisions
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 8:14 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7447: Bring inline comments forward across revision updates

Commits

Restricted Diffusion Commit
rPd8bd3efa2c69: Simplify timeline rendering on Differential revisions

Summary

Ref T7447. Remove the loadInlineComments() by-ref side-effect mess and make this load more direct.

Test Plan

Viewed a revision.
Clicked "Show Older".

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30003.Apr 21 2015, 8:14 PM

epriestley retitled this revision from to Simplify timeline rendering on Differential revisions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7447: Bring inline comments forward across revision updates.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 8:14 PM

btrahan accepted this revision.Apr 21 2015, 10:13 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 21 2015, 10:13 PM

Closed by commit rPd8bd3efa2c69: Simplify timeline rendering on Differential revisions (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 10:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialRevision.php

65 lines

Diff 30007

View Options

src/applications/differential/storage/DifferentialRevision.php

Simplify timeline rendering on Differential revisionsClosedPublicActions