Page MenuHomePhabricator
Differential D12496

Simplify timeline rendering on Differential revisions
ClosedPublic
Actions

Authored by epriestley on Apr 21 2015, 8:14 PM.
Tags
None
Referenced Files
F15520901: D12496.id30003.diff
Sun, Apr 20, 9:04 AM
F15506688: D12496.id30003.diff
Tue, Apr 15, 1:20 PM
F15503851: D12496.id30003.diff
Mon, Apr 14, 1:42 PM
F15484878: D12496.diff
Wed, Apr 9, 8:44 PM
F15480747: D12496.id30007.diff
Tue, Apr 8, 4:12 PM
F15467135: D12496.id30003.diff
Thu, Apr 3, 1:02 PM
F15466716: D12496.id.diff
Thu, Apr 3, 8:52 AM
F15464293: D12496.diff
Wed, Apr 2, 8:16 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7447: Bring inline comments forward across revision updates
Commits
Restricted Diffusion Commit
rPd8bd3efa2c69: Simplify timeline rendering on Differential revisions
Summary

Ref T7447. Remove the loadInlineComments() by-ref side-effect mess and make this load more direct.

Test Plan
  • Viewed a revision.
  • Clicked "Show Older".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30003.Apr 21 2015, 8:14 PM
epriestley retitled this revision from to Simplify timeline rendering on Differential revisions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7447: Bring inline comments forward across revision updates.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 21 2015, 8:14 PM
btrahan accepted this revision.Apr 21 2015, 10:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 10:13 PM
Closed by commit rPd8bd3efa2c69: Simplify timeline rendering on Differential revisions (authored by epriestley, committed by epriestley). · Explain WhyApr 21 2015, 10:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
65 lines

Diff 30007

View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
Phabricator · Built by Phacility