Page MenuHomePhabricator

Filter nonvisible inlines out of changeset inline result set
ClosedPublic

Authored by epriestley on Apr 21 2015, 12:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 24, 7:31 AM
Unknown Object (File)
Thu, Mar 7, 11:38 PM
Unknown Object (File)
Feb 6 2024, 10:03 AM
Unknown Object (File)
Feb 3 2024, 3:22 AM
Unknown Object (File)
Dec 27 2023, 6:09 AM
Unknown Object (File)
Dec 21 2023, 1:08 PM
Unknown Object (File)
Dec 14 2023, 10:53 AM
Unknown Object (File)
Dec 4 2023, 7:28 AM
Subscribers

Details

Summary

Ref T7447. After compiling inlines which will appear on the changeset, remove inlines which

Later stages remove these anyway, so it doesn't change anything to keep them around, but we can filter them out here cheaply.

This will also let us drive the Differential timeline view with the same logic a few diffs from now, to improve how it renders inlines. Generalize things a little bit.

Test Plan
  • Made a comment on the left of diff 1.
  • Made diff 2.
  • Viewed diff 2 vs diff 1.
  • Verified old-left comment was filtered out by the new loop.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Filter nonvisible inlines out of changeset inline result set.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 5:28 PM
This revision was automatically updated to reflect the committed changes.