Page MenuHomePhabricator

Filter nonvisible inlines out of changeset inline result set
ClosedPublic

Authored by epriestley on Apr 21 2015, 12:51 PM.
Tags
None
Referenced Files
F18825085: D12488.id.diff
Thu, Oct 23, 7:31 PM
F18807359: D12488.id29983.diff
Sun, Oct 19, 1:03 AM
F18744906: D12488.diff
Fri, Oct 3, 4:35 AM
F18085519: D12488.id.diff
Aug 5 2025, 7:16 PM
F17916597: D12488.diff
Jul 29 2025, 10:23 PM
F17820052: D12488.id.diff
Jul 26 2025, 1:44 AM
F17795547: D12488.diff
Jul 25 2025, 12:22 AM
F17625336: D12488.diff
Jul 10 2025, 3:11 AM
Subscribers

Details

Summary

Ref T7447. After compiling inlines which will appear on the changeset, remove inlines which

Later stages remove these anyway, so it doesn't change anything to keep them around, but we can filter them out here cheaply.

This will also let us drive the Differential timeline view with the same logic a few diffs from now, to improve how it renders inlines. Generalize things a little bit.

Test Plan
  • Made a comment on the left of diff 1.
  • Made diff 2.
  • Viewed diff 2 vs diff 1.
  • Verified old-left comment was filtered out by the new loop.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Filter nonvisible inlines out of changeset inline result set.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2015, 5:28 PM
This revision was automatically updated to reflect the committed changes.