Page MenuHomePhabricator

Quicksand - update title while navigating about
ClosedPublic

Authored by btrahan on Apr 21 2015, 12:22 AM.
Tags
None
Referenced Files
F14079452: D12487.diff
Fri, Nov 22, 8:16 AM
Unknown Object (File)
Mon, Nov 18, 2:41 PM
Unknown Object (File)
Wed, Nov 13, 10:41 PM
Unknown Object (File)
Sun, Nov 10, 4:14 AM
Unknown Object (File)
Tue, Nov 5, 8:22 PM
Unknown Object (File)
Tue, Oct 29, 6:11 PM
Unknown Object (File)
Oct 20 2024, 1:20 PM
Unknown Object (File)
Oct 17 2024, 11:19 AM
Subscribers

Details

Summary

Fixes T7744. Also fixes a bug where we were copying the response object erroneously; that's not necessary to move around since we cleanly initialize it for each load

Test Plan

from user profile, clicked feed tab and saw new title. clicked calendar tab and saw new title. clicked back and saw feed title and page render.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Quicksand - update title while navigating about.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
344–350

I put this in the durable column behavior because JX.Title is not in Javelin (its in Phabricator). Otherwise, I would have put it in Quickling directly in the draw method.

epriestley edited edge metadata.

Makes sense to me.

This revision is now accepted and ready to land.Apr 21 2015, 5:58 PM
This revision was automatically updated to reflect the committed changes.