Give Phortune carts a proper `isInvoice` flag
ClosedPublic
Actions

Authored by epriestley on Apr 20 2015, 4:12 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP01c99335fdd7: Give Phortune carts a proper `isInvoice` flag

Summary

See some earlier discussion in D11593:

One thing I'm vaguely thinking about is the possibilty that users may be able to invoice one another directly, eventually. For example, we might invoice a contracting client.
We might need an isInvoice flag eventually, but subscriptionPHID is a reasonable stand-in for now.

This adds such a flag.

Test Plan

Generated an ad-hoc invoice and verified it showed up in the right place.
Used bin/phortune invoice to invoice a subscription and verified it worked correctly.
Paid an invoice and saw it leave "pending invoices" status.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29942.Apr 20 2015, 4:12 PM

epriestley retitled this revision from to Give Phortune carts a proper `isInvoice` flag.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 20 2015, 4:12 PM

btrahan accepted this revision.Apr 20 2015, 4:42 PM

btrahan edited edge metadata.

btrahan added inline comments.

src/applications/phortune/storage/PhortuneCart.php
546	Since this was indexed, maybe isInvoice should be too? Practically these tables are tiny so kind of whatevs I think.

This revision is now accepted and ready to land.Apr 20 2015, 4:42 PM

Yeah, we currently always execute queries like:

accountPHID = X AND (some other junk with invoices or status)

...and accountPHID is sufficient to exclude the bulk of the table in most reasonable cases.

I'm going to to add an "unpaid invoices" view to merchants at some point and can see if adding a key does anything for that, since we have real-world cases where all activity on an instance belongs to a single merchant.

Closed by commit rP01c99335fdd7: Give Phortune carts a proper `isInvoice` flag (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 5:05 PM

This revision was automatically updated to reflect the committed changes.