Page MenuHomePhabricator

Support basic ad-hoc invoices in Phortune
ClosedPublic

Authored by epriestley on Apr 20 2015, 3:39 PM.
Tags
None
Referenced Files
F18818283: D12478.id29940.diff
Tue, Oct 21, 10:57 PM
F18804598: D12478.diff
Sat, Oct 18, 10:04 AM
F18742658: D12478.id.diff
Thu, Oct 2, 8:52 PM
F18739568: D12478.diff
Wed, Oct 1, 9:57 PM
F18631538: D12478.id29944.diff
Sep 16 2025, 3:40 PM
F18599924: D12478.diff
Sep 13 2025, 8:36 AM
F18590307: D12478.diff
Sep 12 2025, 5:46 AM
F18565867: D12478.id.diff
Sep 9 2025, 1:48 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP0195e751c64d: Support basic ad-hoc invoices in Phortune
Summary

This allows a merchant to send a user an invoice for something arbitrary, like services rendered.

Two major missing parts:

  • These don't actually get marked as invoices. I'll fix that in the next diff, but it's not entirely trivial because subscriptionPHID is currently overloaded to also mean "is invoice".
  • We don't send email automatically. I don't plan to fix that for now, since all our invoicing needs are covered by personal email.
Test Plan

Merchants have a new "new invoice" option:

Screen_Shot_2015-04-20_at_8.34.29_AM.png (600×988 px, 37 KB)

This leads to selecting a user and account, and then you can generate the invoice (only one actual "purchase" / line item for the moment). You can add a longer-form remarkup description to contextualize the billable items:

Screen_Shot_2015-04-20_at_8.35.24_AM.png (1×2 px, 414 KB)

This sends the invoice and takes you to the merchant order overview screen:

Screen_Shot_2015-04-20_at_8.35.30_AM.png (1×2 px, 453 KB)

For now, you copy/paste that link into a nice personal enterprisey business-to-business email; the recipient sees this:

Screen_Shot_2015-04-20_at_8.35.51_AM.png (1×2 px, 484 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Support basic ad-hoc invoices in Phortune.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/phortune/controller/PhortuneCartViewController.php
52–53

i suggest removing the first "yet".

src/applications/phortune/controller/PhortuneMerchantInvoiceCreateController.php
129

*provide

This revision is now accepted and ready to land.Apr 20 2015, 4:56 PM
epriestley edited edge metadata.
  • Grammar/spelling fixes.
This revision was automatically updated to reflect the committed changes.