Page MenuHomePhabricator
Differential D12471

Tweak browse-more CSS
ClosedPublic
Actions

Authored by chad on Apr 19 2015, 6:37 PM.
Tags
None
Referenced Files
F14053872: D12471.diff
Fri, Nov 15, 8:07 PM
F14043080: D12471.id29928.diff
Tue, Nov 12, 7:31 AM
F14042123: D12471.diff
Tue, Nov 12, 12:40 AM
F14027007: D12471.diff
Fri, Nov 8, 4:10 AM
F14018062: D12471.id29928.diff
Tue, Nov 5, 3:46 AM
F14004884: D12471.diff
Sun, Oct 27, 4:26 AM
F13979917: D12471.id.diff
Oct 19 2024, 7:14 AM
Unknown Object (File)
Oct 13 2024, 7:38 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP0dbd61c2f2b9: Tweak browse-more CSS
Summary

Just adds some space, color.

Test Plan

test a long browse list

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29928.Apr 19 2015, 6:37 PM
chad retitled this revision from to Tweak browse-more CSS.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 19 2015, 6:37 PM
chad added a comment.Apr 19 2015, 6:40 PM

actually, not sure how to test hard-limit. maybe it needs the same padding?

epriestley edited edge metadata.Apr 19 2015, 6:42 PM

Easiest way is to probably:

  • Manually set $hard_limit = 25;.
  • Manually set $limit = 10;.
  • Go to /typeahead/browse/PhabricatorApplicationDatasource/.

Then click "more results" a couple times and you should hit the hard limit.

epriestley added a comment.Apr 19 2015, 6:43 PM

Specifically, those values are set near lines 46-47 of PhabricatorTypeaheadModularDatasourceController.php.

chad updated this revision to Diff 29948.Apr 20 2015, 5:10 PM
chad edited edge metadata.
  • update padding on both hard-limit and more
epriestley accepted this revision.Apr 20 2015, 5:15 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 5:15 PM
Closed by commit rP0dbd61c2f2b9: Tweak browse-more CSS (authored by chad, committed by chad). · Explain WhyApr 20 2015, 5:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
webroot/
rsrc/
css/
aphront/
3 lines

Diff 29962

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/aphront/typeahead-browse.css

Loading...
Phabricator · Built by Phacility