Paths

Table of Contentst

Differential D12471

Tweak browse-more CSS
ClosedPublic
Actions

Authored by chad on Apr 19 2015, 6:37 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP0dbd61c2f2b9: Tweak browse-more CSS

Summary

Just adds some space, color.

Test Plan

test a long browse list

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29928.Apr 19 2015, 6:37 PM

chad retitled this revision from to Tweak browse-more CSS.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 19 2015, 6:37 PM

actually, not sure how to test hard-limit. maybe it needs the same padding?

Easiest way is to probably:

Manually set $hard_limit = 25;.
Manually set $limit = 10;.
Go to /typeahead/browse/PhabricatorApplicationDatasource/.

Then click "more results" a couple times and you should hit the hard limit.

Specifically, those values are set near lines 46-47 of PhabricatorTypeaheadModularDatasourceController.php.

update padding on both hard-limit and more

epriestley accepted this revision.Apr 20 2015, 5:15 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 20 2015, 5:15 PM

Closed by commit rP0dbd61c2f2b9: Tweak browse-more CSS (authored by chad, committed by chad). · Explain WhyApr 20 2015, 5:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

aphront/

typeahead-browse.css

3 lines

Diff 29962

View Options

resources/celerity/map.php