Page MenuHomePhabricator

Tweak browse-more CSS
ClosedPublic

Authored by chad on Apr 19 2015, 6:37 PM.
Tags
None
Referenced Files
F15534304: D12471.id29928.diff
Wed, Apr 23, 11:41 PM
F15513505: D12471.id29928.diff
Thu, Apr 17, 7:22 PM
F15492558: D12471.id29962.diff
Sat, Apr 12, 3:52 PM
F15481841: D12471.id29948.diff
Tue, Apr 8, 11:40 PM
F15478756: D12471.diff
Tue, Apr 8, 2:35 AM
F15472605: D12471.id29948.diff
Sat, Apr 5, 2:54 PM
F15460547: D12471.id.diff
Mon, Mar 31, 11:54 PM
F15442886: D12471.id29948.diff
Mar 27 2025, 1:05 AM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP0dbd61c2f2b9: Tweak browse-more CSS
Summary

Just adds some space, color.

Test Plan

test a long browse list

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Tweak browse-more CSS.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.

actually, not sure how to test hard-limit. maybe it needs the same padding?

Easiest way is to probably:

  • Manually set $hard_limit = 25;.
  • Manually set $limit = 10;.
  • Go to /typeahead/browse/PhabricatorApplicationDatasource/.

Then click "more results" a couple times and you should hit the hard limit.

Specifically, those values are set near lines 46-47 of PhabricatorTypeaheadModularDatasourceController.php.

chad edited edge metadata.
  • update padding on both hard-limit and more
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 5:15 PM
This revision was automatically updated to reflect the committed changes.