Fix typeahead browse dialog paging
ClosedPublic
Actions

Authored by epriestley on Apr 18 2015, 6:08 PM.

Tags

None

Referenced Files

	F13085346: D12461.diff
	Wed, Apr 24, 11:47 PM

	Unknown Object (File)
	Wed, Apr 17, 5:48 PM

	Unknown Object (File)
	Thu, Apr 11, 8:01 AM

	Unknown Object (File)
	Mar 5 2024, 4:41 PM

	Unknown Object (File)
	Feb 5 2024, 2:30 PM

	Unknown Object (File)
	Jan 23 2024, 6:47 AM

	Unknown Object (File)
	Jan 7 2024, 4:21 PM

	Unknown Object (File)
	Jan 3 2024, 6:22 PM

View All Files

Subscribers

epriestley

Details

Reviewers

btrahan
chad

Commits

Restricted Diffusion Commit
rPe5b97cd17c36: Fix typeahead browse dialog paging

Summary

This accidentally got disabled; we need to pull one more result that we'll use to tell if there's a next page.

Test Plan

Saw "more results" again.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29908.Apr 18 2015, 6:08 PM

epriestley retitled this revision from to Fix typeahead browse dialog paging.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 18 2015, 6:08 PM

chad accepted this revision.Apr 18 2015, 6:09 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 18 2015, 6:09 PM

Closed by commit rPe5b97cd17c36: Fix typeahead browse dialog paging (authored by epriestley, committed by epriestley). · Explain WhyApr 18 2015, 6:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

typeahead/

controller/

PhabricatorTypeaheadModularDatasourceController.php

3 lines

Diff 29909

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Fix typeahead browse dialog pagingClosedPublicActions