Page MenuHomePhabricator
Differential D12439

Uncheat Macro datasource browse support
ClosedPublic
Actions

Authored by epriestley on Apr 16 2015, 7:14 PM.
Tags
None
Referenced Files
F14054890: D12439.diff
Sat, Nov 16, 6:12 AM
F14048335: D12439.id29854.diff
Thu, Nov 14, 7:32 AM
F14042553: D12439.diff
Tue, Nov 12, 4:24 AM
F14027031: D12439.diff
Fri, Nov 8, 4:41 AM
F14025698: D12439.id29854.diff
Thu, Nov 7, 7:48 PM
F14010349: D12439.id29854.diff
Thu, Oct 31, 7:13 AM
F14008575: D12439.diff
Wed, Oct 30, 1:24 AM
F13990615: D12439.id.diff
Tue, Oct 22, 5:00 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5750: Implement typeahead browse mode
Commits
Restricted Diffusion Commit
rPba48e05964d4: Uncheat Macro datasource browse support
Summary

Ref T5750. Macro browse support is actually useful (in the meme dialog) and fairly straightforward to implement.

Test Plan
  • Browsed macros.
  • Queired macros.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29854.Apr 16 2015, 7:14 PM
epriestley retitled this revision from to Uncheat Macro datasource browse support.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5750: Implement typeahead browse mode.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 16 2015, 7:14 PM
btrahan accepted this revision.Apr 16 2015, 9:18 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2015, 9:18 PM
Closed by commit rPba48e05964d4: Uncheat Macro datasource browse support (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
query/
42 lines
23 lines
typeahead/
23 lines
search/
engine/
22 lines

Diff 29882

View Options

src/applications/macro/query/PhabricatorMacroQuery.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/macro/typeahead/PhabricatorMacroDatasource.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
Phabricator · Built by Phacility