Page MenuHomePhabricator
Differential D12439

Uncheat Macro datasource browse support
ClosedPublic
Actions

Authored by epriestley on Apr 16 2015, 7:14 PM.
Tags
None
Referenced Files
F18782103: D12439.id29882.diff
Mon, Oct 13, 12:36 AM
F18756941: D12439.id.diff
Sun, Oct 5, 2:29 PM
F18753481: D12439.diff
Sat, Oct 4, 7:01 PM
F18657818: D12439.diff
Tue, Sep 23, 3:32 AM
F18617704: D12439.diff
Sep 14 2025, 9:54 PM
F18505411: D12439.id.diff
Sep 5 2025, 12:38 AM
F18497236: D12439.diff
Sep 4 2025, 5:56 PM
F18486991: D12439.diff
Sep 3 2025, 7:08 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5750: Implement typeahead browse mode
Commits
Restricted Diffusion Commit
rPba48e05964d4: Uncheat Macro datasource browse support
Summary

Ref T5750. Macro browse support is actually useful (in the meme dialog) and fairly straightforward to implement.

Test Plan
  • Browsed macros.
  • Queired macros.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29854.Apr 16 2015, 7:14 PM
epriestley retitled this revision from to Uncheat Macro datasource browse support.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5750: Implement typeahead browse mode.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 16 2015, 7:14 PM
btrahan accepted this revision.Apr 16 2015, 9:18 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 16 2015, 9:18 PM
Closed by commit rPba48e05964d4: Uncheat Macro datasource browse support (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
query/
42 lines
23 lines
typeahead/
23 lines
search/
engine/
22 lines

Diff 29882

View Options

src/applications/macro/query/PhabricatorMacroQuery.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/macro/typeahead/PhabricatorMacroDatasource.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
Phabricator · Built by Phacility