Page MenuHomePhabricator

Fix a fatal on the application list
ClosedPublic

Authored by epriestley on Apr 13 2015, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 3:19 PM
Unknown Object (File)
Nov 18 2024, 1:15 AM
Unknown Object (File)
Nov 8 2024, 2:37 AM
Unknown Object (File)
Oct 19 2024, 12:39 PM
Unknown Object (File)
Oct 16 2024, 2:12 AM
Unknown Object (File)
Oct 14 2024, 9:31 PM
Unknown Object (File)
Oct 13 2024, 10:25 PM
Unknown Object (File)
Oct 10 2024, 5:06 PM
Subscribers

Details

Summary

Fixes T7816. This just punts adding proper cursor-based paging to Applications for now, since they don't have a handy order.

If we get to 101, we can either fix this properly or change the SearchEngine to return 200 results.

(Previously, we generated a cursor only if we absolutely needed to, so this code wasn't called. We generate cursors in some cases where we may not need them now, but the code is simpler this way.)

Test Plan

/applications/ no longer fatals.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a fatal on the application list.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 9:47 PM
This revision was automatically updated to reflect the committed changes.