Page MenuHomePhabricator
Differential D12395

Fix two minor issues
ClosedPublic
Actions

Authored by epriestley on Apr 13 2015, 5:46 PM.
Tags
None
Referenced Files
F14053856: D12395.diff
Fri, Nov 15, 8:03 PM
F14043516: D12395.diff
Tue, Nov 12, 10:46 AM
F14027723: D12395.diff
Fri, Nov 8, 8:59 AM
F14014001: D12395.id29745.diff
Sat, Nov 2, 8:34 PM
F13994177: D12395.id29744.diff
Wed, Oct 23, 4:25 AM
F13974623: D12395.diff
Oct 18 2024, 6:26 AM
F13962192: D12395.id.diff
Oct 15 2024, 8:43 AM
Unknown Object (File)
Oct 9 2024, 12:59 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7814: Traceback viewing config issues list
T7811: Phacility Cluster: Apache exited on repo001.phacility.net
Commits
Restricted Diffusion Commit
rPb467e583585c: Fix two minor issues
Summary

Ref T7811. Fixes two minor issues I observed in the cluster:

  • Sometimes APC doesn't give us key names. Not sure exactly what's up here, but we can do a better job with this.
  • The % in 25% actually needs more escaping, since it's interpreted by both pht() (immediately) and console_format() (later).
Test Plan
  • First one is just from an error log, not sure how to repro offhand.
  • Ran bin/phd help start for the second one.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29744.Apr 13 2015, 5:46 PM
epriestley retitled this revision from to Fix two minor issues.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7811: Phacility Cluster: Apache exited on repo001.phacility.net.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 13 2015, 5:46 PM
btrahan accepted this revision.Apr 13 2015, 5:51 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:51 PM
chad added a task: T7814: Traceback viewing config issues list.Apr 13 2015, 5:55 PM
Closed by commit rPb467e583585c: Fix two minor issues (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 6:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
cache/
spec/
3 lines
daemon/
management/
2 lines

Diff 29745

View Options

src/applications/cache/spec/PhabricatorDataCacheSpec.php

Loading...
View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...
Phabricator · Built by Phacility