Paths

Table of Contentst

Differential D12395

Fix two minor issues
ClosedPublic
Actions

Authored by epriestley on Apr 13 2015, 5:46 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7814: Traceback viewing config issues list
T7811: Phacility Cluster: Apache exited on repo001.phacility.net

Commits

Restricted Diffusion Commit
rPb467e583585c: Fix two minor issues

Summary

Ref T7811. Fixes two minor issues I observed in the cluster:

Sometimes APC doesn't give us key names. Not sure exactly what's up here, but we can do a better job with this.
The % in 25% actually needs more escaping, since it's interpreted by both pht() (immediately) and console_format() (later).

Test Plan

First one is just from an error log, not sure how to repro offhand.
Ran bin/phd help start for the second one.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29744.Apr 13 2015, 5:46 PM

epriestley retitled this revision from to Fix two minor issues.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7811: Phacility Cluster: Apache exited on repo001.phacility.net.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 13 2015, 5:46 PM

btrahan accepted this revision.Apr 13 2015, 5:51 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 5:51 PM

chad added a task: T7814: Traceback viewing config issues list.Apr 13 2015, 5:55 PM

Closed by commit rPb467e583585c: Fix two minor issues (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 6:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

cache/

spec/

PhabricatorDataCacheSpec.php

3 lines

daemon/

management/

PhabricatorDaemonManagementWorkflow.php

2 lines

Diff 29745

View Options

src/applications/cache/spec/PhabricatorDataCacheSpec.php