Differential D12381

Drive conduit result ordering through Query order specifications
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 11:29 PM.

Tags

None

Subscribers

Details

Reviewers

Maniphest Tasks

T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges
T7803: Implement a composite query which unifies cursor paging across subqueries

Commits

Restricted Diffusion Commit
rP09ad69238ee7: Drive conduit result ordering through Query order specifications

Summary

Ref T7803. Ref T5873. Allows Query methods to expose orderings from the underlying Query class nearly-for-free.

Callers can specify a string to use a builtin ordering, or an array to use a low-level column ordering.

Test Plan

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley updated this revision to Diff 29724.Apr 12 2015, 11:29 PM

epriestley retitled this revision from to Drive conduit result ordering through Query order specifications.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7803: Implement a composite query which unifies cursor paging across subqueries, T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 11:29 PM

btrahan accepted this revision.Apr 13 2015, 6:12 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 13 2015, 6:12 PM

Closed by commit rP09ad69238ee7: Drive conduit result ordering through Query order specifications (authored by epriestley). · Explain WhyApr 13 2015, 7:00 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T7909: Allow ascending order for Conduit's maniphest.query's "order" parameter (order-created, order-modified).Apr 24 2015, 9:27 PM

Revision Contents
Changeset List

			Path	Packages
M			src/applications/conduit/controller/PhabricatorConduitConsoleController.php (61 lines)
M			src/applications/conduit/method/ConduitAPIMethod.php (52 lines)
M			src/applications/repository/conduit/RepositoryQueryConduitAPIMethod.php (10 lines)

Diff 29769

src/applications/conduit/controller/PhabricatorConduitConsoleController.php

Loading...

src/applications/conduit/method/ConduitAPIMethod.php

Loading...

src/applications/repository/conduit/RepositoryQueryConduitAPIMethod.php

Loading...