Page MenuHomePhabricator
Differential D12378

Remove getPagingColumn() / getReversePaging()
ClosedPublic
Actions

Authored by epriestley on Apr 12 2015, 9:21 PM.
Tags
None
Referenced Files
F18807164: D12378.id29766.diff
Sat, Oct 18, 11:33 PM
F18802825: D12378.id29711.diff
Fri, Oct 17, 8:34 PM
F18764248: D12378.diff
Tue, Oct 7, 5:05 AM
F18622975: D12378.diff
Sep 15 2025, 1:45 PM
F18567876: D12378.diff
Sep 9 2025, 6:46 PM
F18562029: D12378.diff
Sep 9 2025, 2:05 AM
F18505368: D12378.id.diff
Sep 5 2025, 12:36 AM
F18497146: D12378.diff
Sep 4 2025, 5:54 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7803: Implement a composite query which unifies cursor paging across subqueries
Commits
Restricted Diffusion Commit
rP2794c69db550: Remove getPagingColumn() / getReversePaging()
Summary

Ref T7803. Remove these in favor of more generalized paging and ordering.

Test Plan

Sorted and paged results in various applications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29711.Apr 12 2015, 9:21 PM
epriestley retitled this revision from to Remove getPagingColumn() / getReversePaging().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7803: Implement a composite query which unifies cursor paging across subqueries.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 12 2015, 9:21 PM
btrahan accepted this revision.Apr 13 2015, 5:54 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:54 PM
Closed by commit rP2794c69db550: Remove getPagingColumn() / getReversePaging() (authored by epriestley, committed by epriestley). · Explain WhyApr 13 2015, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
base/
controller/
1 line
config/
controller/
2 lines
conpherence/
query/
5 lines
differential/
query/
5 lines
ponder/
query/
4 lines
1 line
repository/
query/
2 lines
transactions/
query/
10 lines
infrastructure/
query/
policy/
61 lines

Diff 29766

View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/config/controller/PhabricatorConfigHistoryController.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceTransactionQuery.php

Loading...
View Options

src/applications/differential/query/DifferentialHunkQuery.php

Loading...
View Options

src/applications/ponder/query/PonderAnswerQuery.php

Loading...
View Options

src/applications/ponder/query/PonderQuestionQuery.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryQuery.php

Loading...
View Options

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

Loading...
View Options

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...
Phabricator · Built by Phacility