Page MenuHomePhabricator

Modernize ManiphestTask paging and ordering
ClosedPublic

Authored by epriestley on Apr 12 2015, 8:04 PM.
Tags
None
Referenced Files
F15507870: D12372.id29703.diff
Tue, Apr 15, 11:38 PM
F15495488: D12372.id29700.diff
Sun, Apr 13, 4:33 AM
F15487641: D12372.id29765.diff
Thu, Apr 10, 3:43 PM
F15483538: D12372.diff
Wed, Apr 9, 12:57 PM
F15468338: D12372.id29703.diff
Thu, Apr 3, 11:27 PM
F15468337: D12372.id29700.diff
Thu, Apr 3, 11:27 PM
F15422482: D12372.id29765.diff
Mar 22 2025, 8:40 AM
F15417775: D12372.id29703.diff
Mar 20 2025, 6:24 PM
Subscribers

Details

Summary

Ref T7803. The ApplicationSearch integration is still a little rough here, but it seems to have the correct behavior.

The rest of this is now at least relatively sane, cohesive, and properly behaved.

Test Plan
  • Used all grouping and ordering queries in Maniphest. Pagingated results.
  • Used custom field ordering in Maniphest. Paginated results.
  • Paginated through the null section of "Assigned" and "Projects" group-by queries. Pagingation now works correctly (it does not work at HEAD).
  • Ran unit tests covering priority changes.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modernize ManiphestTask paging and ordering.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Fix some issues with subpriority adjustments.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:51 PM
This revision was automatically updated to reflect the committed changes.