Standardize spacing when icons have text
ClosedPublic
Actions

Authored by chad on Apr 12 2015, 4:09 AM.

Tags

None

Referenced Files

	F15398508: D12365.id29689.diff
	Mon, Mar 17, 12:27 AM

	F15388895: D12365.id29688.diff
	Sat, Mar 15, 4:35 AM

	F15382249: D12365.diff
	Fri, Mar 14, 11:29 AM

	F15331463: D12365.diff
	Mar 7 2025, 10:34 AM

	Unknown Object (File)
	Feb 26 2025, 5:05 PM

	Unknown Object (File)
	Feb 19 2025, 4:29 AM

	Unknown Object (File)
	Feb 14 2025, 12:11 AM

	Unknown Object (File)
	Feb 13 2025, 7:00 AM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP3d4079a4891e: Standardize spacing when icons have text

Summary

Our standard icon -> button spacing is 4px, not 8px.

Test Plan

Review search icon in Conpherence Full

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29688.Apr 12 2015, 4:09 AM

chad retitled this revision from to Standardize spacing when icons have text.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 12 2015, 4:09 AM

epriestley accepted this revision.Apr 12 2015, 4:14 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 12 2015, 4:14 AM

Closed by commit rP3d4079a4891e: Standardize spacing when icons have text (authored by chad, committed by chad). · Explain WhyApr 12 2015, 4:25 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

6 lines

webroot/

rsrc/

css/

phui/

phui-icon.css

2 lines

Diff 29689

View Options

resources/celerity/map.php