Page MenuHomePhabricator

Begin formalizing query orders
ClosedPublic

Authored by epriestley on Apr 12 2015, 12:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 1:15 AM
Unknown Object (File)
Thu, Dec 12, 10:43 AM
Unknown Object (File)
Tue, Dec 10, 6:03 PM
Unknown Object (File)
Mon, Dec 9, 6:31 AM
Unknown Object (File)
Mon, Dec 2, 6:00 AM
Unknown Object (File)
Mon, Dec 2, 5:59 AM
Unknown Object (File)
Mon, Dec 2, 5:59 AM
Unknown Object (File)
Mon, Dec 2, 5:55 AM
Subscribers

Details

Summary

Ref T7803. Queries currently have a single getPagingColumn(), which is oversimplified and insufficient to describe many ordering operations. Frequently, orders must span multiple columns.

Move toward an "order vector", which is a list of orderable values like "name, id". These map directly to columns, and are sufficient to actually describe orders. The more modern Query classes (Maniphest, Repository) essentially do this manually anyway.

Test Plan
  • Added and executed unit tests.
  • Browsed around, verified the correct ORDER BY clauses were generated.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Begin formalizing query orders.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 5:03 PM
This revision was automatically updated to reflect the committed changes.