Page MenuHomePhabricator

Remove Herald rule edit log
ClosedPublic

Authored by epriestley on Apr 10 2015, 5:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 12:04 PM
Unknown Object (File)
Tue, Mar 19, 12:04 PM
Unknown Object (File)
Tue, Mar 19, 11:55 AM
Unknown Object (File)
Tue, Mar 19, 11:43 AM
Unknown Object (File)
Fri, Mar 15, 1:34 PM
Unknown Object (File)
Feb 13 2024, 1:19 AM
Unknown Object (File)
Feb 4 2024, 7:11 PM
Unknown Object (File)
Feb 3 2024, 2:56 AM

Details

Summary

Fixes T7601. Ref T7803, weakly (this removes a Query subclass with ad-hoc paging). Herald has a very old edit log which predates transactions and is essentially useless and not really policy-aware. I think it's doing more harm than good; remove it.

Herald rules have proper transactions, but rule edits don't currently render something nice into the transaction log. This is definitely the way forward, but we haven't seen requests for this so don't bother building it for now.

I did put a nice end-cap on the transaction log, though.

Test Plan
  • Viewed Herald UI.
  • Grepped for removed classes and methods.
  • Edited a rule.
  • Viewed rule transaction log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove Herald rule edit log.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/herald/query/HeraldEditLogQuery.php
44–46

Removing this is my tenuous connection to T7803.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 10 2015, 6:02 PM

FWIW The log has solved at least one 'what changed when' mystery for us.

This revision was automatically updated to reflect the committed changes.