Differential D12338

Conpherence - fix recent participant cache
ClosedPublic
Actions

Authored by btrahan on Apr 9 2015, 8:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 22, 4:23 AM

	Unknown Object (File)
	Fri, Jan 17, 2:25 PM

	Unknown Object (File)
	Fri, Jan 17, 7:49 AM

	Unknown Object (File)
	Wed, Jan 15, 4:25 AM

	Unknown Object (File)
	Wed, Jan 15, 4:25 AM

	Unknown Object (File)
	Wed, Jan 15, 4:25 AM

	Unknown Object (File)
	Wed, Jan 15, 4:25 AM

	Unknown Object (File)
	Tue, Jan 14, 11:02 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence

Commits

Restricted Diffusion Commit
rP540e38d20e94: Conpherence - fix recent participant cache

Summary

Ref T7795. This fixes the behavior where you end up with a "a, b, c..." as the list of participants, and yet user a just left.

Test Plan

joined and left a thread. verified database had correct values. observed correct behavior in messages dropdown

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29643.Apr 9 2015, 8:20 PM

btrahan retitled this revision from to Conpherence - fix recent participant cache.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a task: T7795: UNRECOVERABLE FATAL ERROR <<< Call to a member function getName() when using Conpherence.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 9 2015, 8:20 PM

epriestley added inline comments.Apr 9 2015, 8:22 PM

src/applications/conpherence/editor/ConpherenceEditor.php
262–265	I don't understand this -- shouldn't we still update the cache if a user leaves?

btrahan added inline comments.Apr 9 2015, 8:24 PM

src/applications/conpherence/editor/ConpherenceEditor.php
275	this function basically bumps the transaction author to the front, including adding them back if necessary. I can rename stuff so that's more clear.

Ah, okay. Yeah, that wasn't obvious to me.

This revision is now accepted and ready to land.Apr 9 2015, 8:25 PM

rename variable and function to the gist of 'make author most recent participant'

Closed by commit rP540e38d20e94: Conpherence - fix recent participant cache (authored by btrahan, committed by btrahan). · Explain WhyApr 9 2015, 9:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

editor/

ConpherenceEditor.php

26 lines

Diff 29645

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...