Page MenuHomePhabricator

make phriction highlight its diffs as remarkup by default
AbandonedPublic

Authored by sshannin on Apr 8 2015, 2:25 PM.

Details

Summary

might as well default to highlighting as the right color

Test Plan

First there was

and then there was

Diff Detail

Repository
rP Phabricator
Branch
remarkup_for_phriction_diffs
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5197
Build 5215: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

sshannin updated this revision to Diff 29609.Apr 8 2015, 2:25 PM
sshannin retitled this revision from to phriction uses remarkup and should highlight its diff as remarkup by default.
sshannin updated this object.
sshannin edited the test plan for this revision. (Show Details)
sshannin added a project: Phriction.
sshannin retitled this revision from phriction uses remarkup and should highlight its diff as remarkup by default to make phriction highlight its diffs as remarkup by default.Apr 8 2015, 2:26 PM
sshannin edited edge metadata.

I think this will break the "Highlight As..." action. Choosing "Highlight As..." and then selecting "Rainbow" should adjust the highlighting to rainbow, because it's confusing if there's some other behavior. Does "Highlight As..." still work?

eadler added a subscriber: eadler.Jul 3 2015, 7:56 PM
epriestley requested changes to this revision.Nov 23 2015, 4:19 PM
epriestley added a reviewer: epriestley.

This needs a more sophisticated approach which doesn't break "Highlight As...".

I think I looked at it briefly but it isn't trivial.

Per T3353, this view is on its way out for human-language text anyway.

This revision now requires changes to proceed.Nov 23 2015, 4:19 PM
sshannin abandoned this revision.Nov 23 2015, 9:02 PM

That matches what I found as well (although I'm sure trivial means different things to each of us :p). Abandoning in favor of T3353