Differential D12324

make phriction highlight its diffs as remarkup by default
AbandonedPublic
Actions

Authored by • sshannin on Apr 8 2015, 2:25 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7783: phriction diffs don't default to remarkup

Summary

might as well default to highlighting as the right color

Test Plan

First there was

and then there was

Diff Detail

Repository

rP Phabricator

Branch

remarkup_for_phriction_diffs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5197
Build 5215: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

• sshannin updated this revision to Diff 29609.Apr 8 2015, 2:25 PM

• sshannin retitled this revision from to phriction uses remarkup and should highlight its diff as remarkup by default.

• sshannin updated this object.

• sshannin edited the test plan for this revision. (Show Details)

• sshannin added a project: Phriction.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 8 2015, 2:25 PM

Herald added a subscriber: epriestley. · View Herald Transcript

• sshannin retitled this revision from phriction uses remarkup and should highlight its diff as remarkup by default to make phriction highlight its diffs as remarkup by default.Apr 8 2015, 2:26 PM

• sshannin edited edge metadata.

I think this will break the "Highlight As..." action. Choosing "Highlight As..." and then selecting "Rainbow" should adjust the highlighting to rainbow, because it's confusing if there's some other behavior. Does "Highlight As..." still work?