Page MenuHomePhabricator

Emit cache setup issues from cache specs
ClosedPublic

Authored by epriestley on Apr 7 2015, 11:54 PM.
Tags
None
Referenced Files
F14062629: D12318.diff
Mon, Nov 18, 1:20 PM
F14049183: D12318.id29599.diff
Thu, Nov 14, 11:36 AM
F14046277: D12318.diff
Wed, Nov 13, 7:59 PM
F14034275: D12318.diff
Sat, Nov 9, 11:23 PM
F14021721: D12318.diff
Wed, Nov 6, 11:43 AM
F14004830: D12318.diff
Sun, Oct 27, 3:22 AM
F13995388: D12318.id.diff
Wed, Oct 23, 12:31 PM
F13991650: D12318.diff
Tue, Oct 22, 11:59 AM
Subscribers

Details

Summary

Ref T5501. Currently, we emit some bad warnings about, e.g., "apc.stat" on PHP 5.5+ systems with OPcache, where the warnings are not relevant.

Generate and raise warnings out of the CacheSpec pipeline so we only run relevant code.

Test Plan

Faked various warnings and saw them render correctly.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Emit cache setup issues from cache specs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
src/applications/config/option/PhabricatorCoreConfigOptions.php
212

Oh, this also sets a default cache namespace.

If we don't do this, the cachekey table identifies all keys as belonging to some other namespace.

btrahan edited edge metadata.
btrahan added inline comments.
src/applications/cache/spec/PhabricatorCacheSpec.php
84

Will this eventually say "or a later version" or just kind of whatevs? Maybe we should maintain a single something with our recommend versions that we can refer folks to here?

Just musing about doc decay for this sort of thing...

This revision is now accepted and ready to land.Apr 8 2015, 5:17 PM

There will probably never be a later version, APC is essentially obsolete in modern PHP.

This revision was automatically updated to reflect the committed changes.